New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows support + Stability #3
Conversation
Thanks for this! I'm surprised this is all it takes to get something working on Windows. |
You're welcome 😃 Check the #6. I cannot still get it running for the |
should solve tshort#6 (comment)
For more robust compiling across platforms, PackageCompilerX is a good place to look. |
On my system I get the error that It happens because of this:
There is no map for Documentation for all the C types is here: https://docs.julialang.org/en/v1/base/c/#Base.Cchar |
I couldn't figure out how to edit your branch. See the following for a version that compiles standalone executables on Windows. https://github.com/tshort/StaticCompiler.jl/blob/aminya-extra/test/standalone-exe.jl Feel free to add that to your branch and make changes if needed. |
Because I am an outsider collaborator, similar to how I don't have direct access to this repository, you don't have access to my fork. That's why I was asking for transferring this repo to Julia-Embedded 😄 I will edit it. |
Another pain point for Windows is that an exe wants all dll's in the path or in the same folder. I just blindly copied them to the standalone folder. |
Co-Authored-By: Tom Short <tshort.rlists@gmail.com>
This comment has been minimized.
This comment has been minimized.
Windows passed here: https://travis-ci.com/tshort/StaticCompiler.jl/jobs/261964286 |
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
========================================
Coverage ? 92.7%
========================================
Files ? 7
Lines ? 288
Branches ? 0
========================================
Hits ? 267
Misses ? 21
Partials ? 0
Continue to review full report at Codecov.
|
Windows passes now https://travis-ci.com/aminya/StaticCompiler.jl/builds/138874773 |
2530270
to
c7c8c03
Compare
I couldn't fix #8 |
Tests pass locally for me on Windows and Linux, so I'll probably merge this as is. I'll give it a couple of days to see if I can figure out why Travis fails. |
That's good! Yeah, we can do more stuff on other pull requests. For example, we need to move |
Agreed. There's lot's more stuff to do! On I'm more worried about the core compiling functionality. That needs work to handle more code. |
Fixes #2, #4, #6, and #5